Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2 docs update #233

Merged
merged 80 commits into from
Apr 6, 2019
Merged

0.2 docs update #233

merged 80 commits into from
Apr 6, 2019

Conversation

j-wags
Copy link
Member

@j-wags j-wags commented Apr 6, 2019

This PR does a lot of housekeeping, including:

New docs can be found here: https://open-forcefield-toolkit.readthedocs.io/en/0-2-docs-update/

j-wags added 30 commits April 4, 2019 14:14
…pdate

# Conflicts:
#	The-SMIRNOFF-force-field-format.md
#	docs/releasehistory.rst
#	openforcefield/tests/test_forcefield.py
@j-wags
Copy link
Member Author

j-wags commented Apr 6, 2019

This pull request fixes 1 alert when merging eaaf7db into 32273d5 - view on LGTM.com

fixed alerts:

  • 1 for Testing equality to None

Comment posted by LGTM.com

@j-wags
Copy link
Member Author

j-wags commented Apr 6, 2019

@jchodera -- Remaining questions not addressed in comments above:

Should we rename Chemical-starting-points.md to FAQ.md to more accurately reflect its title and contents?

Good idea. I went ahead and did it.

Eventually, we may want the SMIRNOFF spec to live in its own separate GitHub repo.

I'm ambivalent, but haven't thought too hard about this. Added to openforcefield/standards#48. We can make this its own issue if it builds traction.

@j-wags
Copy link
Member Author

j-wags commented Apr 6, 2019

This pull request fixes 1 alert when merging 3f184a1 into 32273d5 - view on LGTM.com

fixed alerts:

  • 1 for Testing equality to None

Comment posted by LGTM.com

Copy link
Member

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're good to go!

@j-wags j-wags merged commit aa4d9b9 into topology Apr 6, 2019
@j-wags
Copy link
Member Author

j-wags commented Apr 6, 2019

This pull request fixes 1 alert when merging e2d76b4 into 32273d5 - view on LGTM.com

fixed alerts:

  • 1 for Testing equality to None

Comment posted by LGTM.com

@andrrizzi andrrizzi deleted the 0-2-docs-update branch April 7, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants