-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RDKit versions used in tests #1942
Conversation
Looks like this is getting cheminformatics-y. Mind if I switch this on to my plate to dig into the changes? |
Please feel free to! I think it might come down to why the behavior around #1942 (comment) changed in some of the matrix but not the rest. I'm happy to wash my hands of this if you think you can read the tea leaves |
Cool, I'll take this over then! |
I'll consider my final round of cleanups to be equivalent to my review and will merge this PR once I've made them. |
Great - removing skipped molecules meshes with my surface-level understanding of those "failures" being improvements |
Work around