Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RDKit versions used in tests #1942

Merged
merged 11 commits into from
Oct 4, 2024
Merged

Update RDKit versions used in tests #1942

merged 11 commits into from
Oct 4, 2024

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Oct 2, 2024

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.73%. Comparing base (df251d3) to head (bad5456).
Report is 1 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson changed the title Test new RDKit constraint Update RDKit versions used in tests Oct 3, 2024
@mattwthompson mattwthompson mentioned this pull request Oct 3, 2024
4 tasks
@j-wags
Copy link
Member

j-wags commented Oct 3, 2024

Looks like this is getting cheminformatics-y. Mind if I switch this on to my plate to dig into the changes?

@mattwthompson
Copy link
Member Author

mattwthompson commented Oct 3, 2024

Please feel free to! I think it might come down to why the behavior around #1942 (comment) changed in some of the matrix but not the rest. I'm happy to wash my hands of this if you think you can read the tea leaves

@j-wags j-wags self-assigned this Oct 3, 2024
@j-wags
Copy link
Member

j-wags commented Oct 3, 2024

Cool, I'll take this over then!

@j-wags
Copy link
Member

j-wags commented Oct 4, 2024

The molecules that are newly failing (er, passing) stereo tests are somewhat exotic rings with nitrogens. Loading both with RDKit 2022 leads to undefined stereo errors on nitrogens[1], but not any more in RDKit 2024. Without fully delving into the context of all our past decisions about interop, raising fewer stereo errors here is a GOOD thing, since the molecules are 3D to begin with, so the idea that they're missing stereo is nonsensical. So I have no hesitation removing molecules from this xfail list.

Screenshot 2024-10-04 at 2 07 39 PM Screenshot 2024-10-04 at 2 07 07 PM

[1]

openff.toolkit.utils.exceptions.UndefinedStereochemistryError: Unable to make OFFMol from RDMol: RDMol has unspecified stereochemistry. RDMol name: DrugBank_7124Undefined chiral centers are:
 - Atom N (index 43)

@j-wags
Copy link
Member

j-wags commented Oct 4, 2024

I'll consider my final round of cleanups to be equivalent to my review and will merge this PR once I've made them.

@j-wags j-wags marked this pull request as ready for review October 4, 2024 22:59
@j-wags j-wags merged commit 6aa989e into main Oct 4, 2024
18 checks passed
@j-wags j-wags deleted the update-rdkit branch October 4, 2024 23:12
@mattwthompson
Copy link
Member Author

Great - removing skipped molecules meshes with my surface-level understanding of those "failures" being improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants