Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] Test osx arm64 #1913

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DNM] Test osx arm64 #1913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed5ad00
Test CI on osx-ar64
mikemhenry Jul 26, 2024
db9ab54
save some CO2
mikemhenry Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-12]
os: [macos-14]
Copy link
Member

@mattwthompson mattwthompson Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
os: [macos-14]
os: [ubuntu-latest, macos-12, macos-latest]

This changeset is strictly unnecessary but I think it'd be useful to have here instead of downstream

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I had intended to just test osx-arm64 -- but would you like to get osx-arm64 added into your CI matrix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to @j-wags in this project but it makes sense to test on all three IMHO

python-version: ["3.10", "3.11", "3.12"]
rdkit: [true, false]
openeye: [true, false]
Expand Down