Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize fixes #1751

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Visualize fixes #1751

wants to merge 14 commits into from
+119 −91

Commits on Oct 19, 2023

  1. Fix Molecule.visualize() overrides

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4471cb9 View commit details
    Browse the repository at this point in the history

  2. Fix path to Ipython display module

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    d934f2f View commit details
    Browse the repository at this point in the history

  3. Correct docs and types re: show_all_hydrogens w/ backend='nglview'

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    81e7170 View commit details
    Browse the repository at this point in the history

  4. Clean up Molecule.visualize docstring and code

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    840dfd3 View commit details
    Browse the repository at this point in the history

  5. remove ensure_correct_connectivity and update docstring

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4a3197e View commit details
    Browse the repository at this point in the history

  6. Display multiple bonds when available

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6f05c45 View commit details
    Browse the repository at this point in the history

  7. Document that bonds may be deduced from positions in mol.visualize()

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c003634 View commit details
    Browse the repository at this point in the history

  8. Write PDB with RDKit when visualizing topologies

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e80b347 View commit details
    Browse the repository at this point in the history

  9. Fall back to OpenMM if RDKit unavailable and document

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    0dc93d0 View commit details
    Browse the repository at this point in the history

  10. Update changelog

    @Yoshanuikabundi
    Yoshanuikabundi committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    32e8700 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Merge remote-tracking branch 'upstream/main' into visualize-fixes

    @mattwthompson
    mattwthompson committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    50bdb9a View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Ignore missing type annotations in rdkit

    @Yoshanuikabundi
    Yoshanuikabundi committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    4ff6bab View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Merge branch 'main' into visualize-fixes

    @Yoshanuikabundi
    Yoshanuikabundi authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    584a039 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge branch 'main' into visualize-fixes

    @j-wags
    j-wags authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a57a88d View commit details
    Browse the repository at this point in the history