Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow unique_molecules=None when required #1742

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Do not allow unique_molecules=None when required #1742

wants to merge 5 commits into from

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Oct 13, 2023 •
edited
Loading

Closes #1485

  • Removes MissingUniqueMoleculesError which should have always been a TypeError
    • Ensured this case is not handled in MissingUniqueMoleculesError (not that it could be)
  • Tag issue being addressed
  • Add tests
  • Update docstrings/documentation, if applicable
  • Lint codebase
  • Update changelog

@mattwthompson mattwthompson marked this pull request as ready for review February 22, 2024 16:36
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited
Loading

Codecov Report

Merging #1742 (b2131cb) into main (118918c) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags Awaiting requested review from j-wags

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unique_molecules argument should not be optional
1 participant
@mattwthompson