Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception when Topology.from_openmm is given virtual sites #1667

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Raise exception when Topology.from_openmm is given virtual sites #1667

merged 2 commits into from
Jul 16, 2023

Conversation

mattwthompson
Copy link
Member

Resolves #1598

@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited
Loading

Codecov Report

Merging #1667 (8f302ef) into main (dbd3e9e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review July 6, 2023 14:04
j-wags
j-wags approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mattwthompson!

@j-wags j-wags merged commit 0e4af26 into main Jul 16, 2023
14 checks passed
@j-wags j-wags deleted the fix-1598 branch July 16, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topology.from_openmm chokes on virtual sites
2 participants
@mattwthompson @j-wags