Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove binder #1614

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Remove binder #1614

merged 2 commits into from
Jun 30, 2023

Conversation

mattwthompson
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 15, 2023 •
edited
Loading

Codecov Report

Merging #1614 (155a9af) into main (1456fe0) will decrease coverage by 1.62%.
The diff coverage is n/a.

❗ Current head 155a9af differs from pull request most recent head 51c6498. Consider uploading reports for the commit 51c6498 to get more accurate results

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review May 15, 2023 15:50
@mattwthompson
Copy link
Member Author

In #1613 the binder links started to fail (at a rate less than 100%) so we may want to remove them.

This can all be replaced with Google Colab, if we want to use it.

j-wags
j-wags approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattwthompson - This is good to go since we'll have colab on the centralized examples page.

@j-wags j-wags merged commit 1826de6 into main Jun 30, 2023
11 of 13 checks passed
@j-wags j-wags deleted the no-binder branch June 30, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @j-wags