Skip to content

Commit

Permalink
Don't trust RDKit stubs
Browse files Browse the repository at this point in the history
  • Loading branch information
mattwthompson committed Oct 3, 2024
1 parent 75da94a commit da2dba2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,10 @@ jobs:

- name: Run mypy
# subtle differences in Python/mypy versions, just keep it passing on one
if: ${{ matrix.rdkit == true && matrix.openeye && matrix.python-version == 3.10 }}
# prefer having htis back to rdkit == true, but builds often have bugs in stubs and
# there are other bugs/subtleties (in the source code and builds) that reduce the number
# of available builds
if: ${{ matrix.rdkit == false && matrix.openeye && matrix.python-version == 3.10 }}
run: mypy -p "openff.toolkit"

- name: Run unit tests
Expand Down

0 comments on commit da2dba2

Please sign in to comment.