Skip to content

Commit

Permalink
Moved "Open Questions" from the SMIRNOFF spec page and put them in #120
Browse files Browse the repository at this point in the history
  • Loading branch information
j-wags committed Apr 5, 2019
1 parent f998e2c commit 4d26d0c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 14 deletions.
7 changes: 0 additions & 7 deletions The-SMIRNOFF-force-field-format.md
Original file line number Diff line number Diff line change
Expand Up @@ -675,12 +675,5 @@ This is a backwards-incompatible overhaul of the SMIRNOFF 0.1 draft specificatio

Initial draft specification.

## Open Questions


### How should we use multiple conformations in charging?

Should we follow the RESP approach, where the charges or averaged?
Or the ELF approach, where we use some kind of energy function to evaluate which single conformer is used to compute which conformer is to be used for quantum chemical calculations?
What scheme should we use to generate the conformers in a deterministic manner?

10 changes: 4 additions & 6 deletions docs/examples.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ These examples are described in more detail below.

.. mdinclude:: ../examples/SMIRNOFF_comparison/README.md

.. mdinclude:: ../examples/forcefield_modification/README.md

.. mdinclude:: ../examples/mixedFF_structure/README.md

.. mdinclude:: ../examples/partial_bondorder/README.md
.. mdinclude:: ../examples/conversion_amber_gromacs/README.md

.. mdinclude:: ../examples/host_guest_simulation/README.md
.. mdinclude:: ../examples/forcefield_modification/README.md

.. mdinclude:: ../examples/label_molecule/README.md

.. mdinclude:: ../examples/mixedFF_complex/README.md
2 changes: 1 addition & 1 deletion openforcefield/topology/molecule.py
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,7 @@ class Bond(Serializable):
Attributes
----------
atom1, atom2 : Atom
atom1, atom2 : openforcefield.topology.Atom
Atoms involved in the bond
bondtype : int
Discrete bond type representation for the Open Forcefield aromaticity model
Expand Down

0 comments on commit 4d26d0c

Please sign in to comment.