Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get to avoid KeyError on missing cmiles attribute #300

Merged
merged 14 commits into from
Oct 21, 2024
Merged

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    f64d35b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. add failing test for #299

    ntBre committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2ab5d7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bbb9a06 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abd6d7c View commit details
    Browse the repository at this point in the history
  4. run pre-commit hooks

    ntBre committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0934011 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. switch to logging from warnings

    based on these
    docs (https://docs.python.org/3/howto/logging.html#when-to-use-logging) warnings
    should be used "if the issue is avoidable and the client application should be
    modified to eliminate the warning," (like a deprecation warning) while logging a
    warning should be used "if there is nothing the client application can do about
    the situation, but the event should still be noted." I think this warning is
    closer to the latter case, where there's not much a user can do about this, and
    this allows us to filter these warnings by default, which I don't think is
    possible with the warnings module
    ntBre committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1dbd9a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e70ec87 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b06d4c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4677298 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eedf0d6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    666c343 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. update release notes

    ntBre committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f93d7fe View commit details
    Browse the repository at this point in the history
  2. fix extra colon

    ntBre committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a4a7b03 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. fix minor typos

    ntBre committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    89b0564 View commit details
    Browse the repository at this point in the history