-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use get
to avoid KeyError on missing cmiles attribute
#300
Merged
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f64d35b - Browse repository at this point
Copy the full SHA f64d35bView commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ab5d7e - Browse repository at this point
Copy the full SHA 2ab5d7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbb9a06 - Browse repository at this point
Copy the full SHA bbb9a06View commit details -
Configuration menu - View commit details
-
Copy full SHA for abd6d7c - Browse repository at this point
Copy the full SHA abd6d7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0934011 - Browse repository at this point
Copy the full SHA 0934011View commit details
Commits on Oct 9, 2024
-
switch to logging from warnings
based on these docs (https://docs.python.org/3/howto/logging.html#when-to-use-logging) warnings should be used "if the issue is avoidable and the client application should be modified to eliminate the warning," (like a deprecation warning) while logging a warning should be used "if there is nothing the client application can do about the situation, but the event should still be noted." I think this warning is closer to the latter case, where there's not much a user can do about this, and this allows us to filter these warnings by default, which I don't think is possible with the warnings module
Configuration menu - View commit details
-
Copy full SHA for 1dbd9a0 - Browse repository at this point
Copy the full SHA 1dbd9a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e70ec87 - Browse repository at this point
Copy the full SHA e70ec87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b06d4c - Browse repository at this point
Copy the full SHA 4b06d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4677298 - Browse repository at this point
Copy the full SHA 4677298View commit details -
Configuration menu - View commit details
-
Copy full SHA for eedf0d6 - Browse repository at this point
Copy the full SHA eedf0d6View commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 666c343 - Browse repository at this point
Copy the full SHA 666c343View commit details
Commits on Oct 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f93d7fe - Browse repository at this point
Copy the full SHA f93d7feView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4a7b03 - Browse repository at this point
Copy the full SHA a4a7b03View commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 89b0564 - Browse repository at this point
Copy the full SHA 89b0564View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.