Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also test on M1 hardware #293

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Also test on M1 hardware #293

merged 2 commits into from
Sep 26, 2024

Conversation

mattwthompson
Copy link
Member

Description

We found some test failures on M1 hardware, which is not tested here.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

@mattwthompson
Copy link
Member Author

mattwthompson commented Jul 23, 2024 •
edited
Loading

This drops the QCArchive stack down to 0.54 because of MolSSI/QCFractal#846

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.43%. Comparing base (357e2de) to head (803b07d).
Report is 4 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review August 14, 2024 14:39
@j-wags j-wags merged commit cc3f23e into main Sep 26, 2024
8 checks passed
@j-wags j-wags deleted the test-m1 branch September 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @j-wags