Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call python setup.py #212

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Do not call python setup.py #212

merged 5 commits into from
Jul 24, 2023

Conversation

mattwthompson
Copy link
Member

Description

I'm working on #211

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Ensure local installation of package works

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #212 (fec661e) into main (9c9f449) will decrease coverage by 95.01%.
The diff coverage is n/a.

❗ Current head fec661e differs from pull request most recent head c3eb9eb. Consider uploading reports for the commit c3eb9eb to get more accurate results

Additional details and impacted files

@mattwthompson
Copy link
Member Author

There's an error bubbling up from QCEngine:

__________ ERROR collecting openff/qcsubmit/tests/test_submissions.py __________
openff/qcsubmit/tests/test_submissions.py:9: in <module>
    from qcengine.testing import has_program
../../../micromamba-root/envs/qcsubmit-test-psi4/lib/python3.8/site-packages/qcengine/testing.py:173: in <module>
    "psi4": is_program_new_enough("psi4", "1.2"),
../../../micromamba-root/envs/qcsubmit-test-psi4/lib/python3.8/site-packages/qcengine/testing.py:62: in is_program_new_enough
    candidate_version = qcng.get_program(program).get_version()
../../../micromamba-root/envs/qcsubmit-test-psi4/lib/python3.8/site-packages/qcengine/programs/psi4.py:91: in get_version
    self.version_cache[which_prog] = safe_version(exc["stdout"].split()[-1])
E   IndexError: list index out of range

I can't find documentation around any version restrictions around non-ancient versions (surely we're not installing 1.2) and the failure coming from parsing STDOUT implies that it's just not installed correctly. I raised #214 which might help this.

@jthorton
Copy link
Contributor

There's an error bubbling up from QCEngine:

This normally means psi4 was not installed correctly. The current pins in the env were what I could get to work consistently and were taken from qcengine I am not sure why this would suddenly break though.

@mattwthompson mattwthompson marked this pull request as ready for review July 24, 2023 14:15
@mattwthompson
Copy link
Member Author

Looks like the installation step went fine and it's working on the tests, which have gone for a half hour now and will probably hang, so I'm cancelling them now.

Merging this now as per #218 (comment)

@mattwthompson mattwthompson merged commit c17e96e into main Jul 24, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants