Expose trajectory protocol for optimization datasets #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set the default trajectory protocol for optimizations to be `initial_and_final` in order to conserve space where possible. Choosing another option is an opt-in choice for the submitter.
|
Going to wait on this for the QCFractal refactor, as there are literally two places where protocols should go on an optimization entry, and it is not clear right now which one to use. We could try just attaching to both, but this may prove to be a temporary solution anyway until the refactor is out. |
We want to remove `optimization_trajectory` from QCSpec next; doesn't belong there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We set the default trajectory protocol for optimizations to be
initial_and_finalin order to conserve space where possible.Choosing another option is an opt-in choice for the submitter.
Todo
Status