Exclude data files from conda/Python packages #1329
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1329 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 72 72
Lines 6316 6316
=======================================
Hits 5927 5927
Misses 389 389 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| - name: Run example notebooks | ||
| run: | | ||
| python -m pytest -c pyproject.toml --nbval-lax --dist loadscope -n logical --durations=20 examples/ \ | ||
| python -m pytest -x -c pyproject.toml --nbval-lax --dist loadscope -n logical --durations=20 examples/ \ |
There was a problem hiding this comment.
This was originally included for debugging but I think it's worth leaving in
Upsides:
- When there is a critical failure, like high-level imports breaking, we get ~100 lines back instead of ~100 bazillion
- Quicker failure reporting when something goes wrong
Downsides:
- Prone to flakiness
- Misses other failures if a change causes multiple
|
I'm comparing this to OpenFE's config and I think this will start to fix the problem of |
Debug Debug More debugging Different syntax? https://github.com/openforcefield/openff-nagl/blob/dfc8102889b93b34582535fcee20932e4d2df7de/pyproject.toml#L46-L49 Revert "Debug" This reverts commit afaaa70.
mattwthompson
force-pushed
the
do-not-package-test-data
branch
from
0023a5f to
0772a1b
Compare
| [tool.setuptools.packages] | ||
| find = {} | ||
| [tool.setuptools.packages.find] | ||
| include = [ 'openff.interchange*' ] | ||
| exclude = [ 'openff.interchange._tests.data*' ] |
There was a problem hiding this comment.
IIUC this shoud be telling Setuptools where the Python files actually are; currently it just crawls around until it finds Python files, so docs/conf.py is treated as importantly as openff/interchange/components/interchange.py
I think so! I haven't tried to track that issue down and just laugh a bit as it zips past my screen. Once thing to keep in mind is that you can also use this field to control package data files https://setuptools.pypa.io/en/latest/userguide/datafiles.html#exclude-package-data |
Description
This is more or less copied from openforcefield/openff-nagl#216
Something like 80% of the size of this package (when ... packaged) is data files that are only needed for testing: