Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix charge ordering in .prmtop files #1045

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix charge ordering in .prmtop files #1045

merged 2 commits into from
Aug 29, 2024

Conversation

mattwthompson
Copy link
Member

Description

Resolves #1033

Checklist

  • Add tests
    • Other tests to add?
  • Lint
  • Update docstrings

@mattwthompson mattwthompson mentioned this pull request Aug 28, 2024
Closed
3 tasks
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (70b925f) to head (af9ba48).
Report is 3 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review August 28, 2024 18:34
lukasbaldauf
lukasbaldauf approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@lukasbaldauf lukasbaldauf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄 Thank you for fixing!

@mattwthompson mattwthompson merged commit 5ed1daa into main Aug 29, 2024
20 of 21 checks passed
@mattwthompson mattwthompson deleted the fix-1033 branch August 29, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasbaldauf lukasbaldauf lukasbaldauf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @lukasbaldauf