-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of from_openmm
and related features
#1008
Conversation
from_openmm
and related features
Could I get a quick once-over (aka find my typos, even though I edited it once myself)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two typos, and then a bunch of optional rephrasings to reduce parentheticals and keep a single logical flow. Looks good, this is very useful info! I've also suggested using a Sphinx cross-reference to link to the appropriate page, and I think the note might need to be moved to different functions?
docs/using/edges.md
Outdated
|
||
### Modified masses are ignored | ||
|
||
The OpenFF Toolkit does not support isotopes or modifiying masses from the values defined in the periodic table. In the `Topology` and `Molecule` classes, particles masses are defined only by their atomic number. When topologies are read from OpenMM, the particle mass is ignored and the atomic number of the element is read and used to define the atomic properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternate:
The OpenFF Toolkit does not support isotopes or modifiying masses from the values defined in the periodic table. In the `Topology` and `Molecule` classes, particles masses are defined only by their atomic number. When topologies are read from OpenMM, the particle mass is ignored and the atomic number of the element is read and used to define the atomic properties. | |
The OpenFF Toolkit does not support isotopes or modifying masses from the values defined in the periodic table. In the `Topology` and `Molecule` classes, particles masses are defined only by their atomic number. When topologies are read from OpenMM, the particle mass is ignored and the atomic number of the element is read and used to define the atomic properties. |
Co-authored-by: Josh A. Mitchell <[email protected]>
Closes #1006 |
Note this is going into the 0.4 line, so these changes won't be reflected in 0.3 releases |
Description
In part resolves #1004 #1005 #1007