Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #29 #30

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

mikemhenry
Copy link
Contributor

Temp fix to #29, not sure if you want this or just want to wait until conda-incubator/condacolab#63 gets merged in and a new release lands on PyPI

@Yoshanuikabundi
Copy link
Contributor

Thanks for this Mike! We're currently relying on an older cache of the Colab notebooks until I get a chance to sort #27 out, so if we did merge this it wouldn't do anything until that's merged unfortunately... by which point condacolab may well be updated.

We could patch the cache directly (the _cookbook_data branch: https://github.com/openforcefield/openff-docs/tree/_cookbook_data/main/build/cookbook/colab/openforcefield)... let me have a think about whether that's something I want to do.

@Yoshanuikabundi
Copy link
Contributor

I've fixed the issue by manually editing the cache. I'm going to merge this as well in case I fix the builds before this is fixed upstream. CI is failing because it doesn't work off a branch. But this change can't break anything worse than its already broken!

@Yoshanuikabundi Yoshanuikabundi merged commit 303a817 into openforcefield:main Jan 25, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants