install latest openfe and gufe as a canary to catch upstream changes #204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 22 22
Lines 2735 2735
=======================================
Hits 2263 2263
Misses 472 472 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks great @mikemhenry! Sorry for the delay in reviewing this one! Feel free to merge if satisfied!
|
Actually, think this runs into the same problem that prompted #203: installing new I don't know of a good workaround for this. |
| @@ -42,6 +47,9 @@ jobs: | |||
| environment-file: devtools/conda-envs/test.yml | |||
| activate-environment: alchemiscale-test | |||
|
|
|||
| - name: "Install openfe & gufe from latest source" | |||
| if: ${{ matrix.deps-versions == 'openfe-latest' }} | |||
| run: pip install --no-deps git+https://github.com/OpenFreeEnergy/gufe git+https://github.com/OpenFreeEnergy/openfe | |||
There was a problem hiding this comment.
| run: pip install --no-deps git+https://github.com/OpenFreeEnergy/gufe git+https://github.com/OpenFreeEnergy/openfe | |
| run: | | |
| pip install --no-deps git+https://github.com/OpenFreeEnergy/gufe git+https://github.com/OpenFreeEnergy/openfe | |
| mamba install kartograff |
There was a problem hiding this comment.
This should fix the issue highlighted here #204 (comment)
We have to manually install packages to make the canary pass, that way we can "catch" the upstream change. We can also not do that and just have the CI fail until a new openfe releases comes out and fixes the dependency issue
No description provided.