feat: add quality facet ingredient percent over hundred #8094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧽 Data quality
Codecov Report
@@ Coverage Diff @@
## main #8094 +/- ##
==========================================
+ Coverage 45.20% 45.23% +0.02%
==========================================
Files 102 102
Lines 20272 20283 +11
Branches 4639 4641 +2
==========================================
+ Hits 9164 9175 +11
Misses 10011 10011
Partials 1097 1097
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stephanegigandet
approved these changes
Feb 13, 2023
|
You want it to be a warning instead of an error? I will change it later during the week. |
…h-specified-percent-greater-than-200
|
Kudos, SonarCloud Quality Gate passed!
|
|
Looks good to me, thanks a lot Benoît. I feel that this is clearly an error and not a warning but we can wait and see the first products. |
benbenben2
deleted the
feat_add_quality_facet_ingredient_percent_over_hundred
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2168
there is ingredients>id
if percentage is given: "ingredients>percent"
if it is not given: "ingredients>" (the key "percent" is missing)
option 1 is preferred because it is the main language that is used to analyze ingredients + option 2 would have to re-extract percentage from entire list of ingredients, which is not without risk (maybe something can be above 100% in the text but not related to ingredients)
name?
en:ingredients- + description (similar to existing quality facets)
en:ingredients-extracted-ingredient-from-picture-with-more-than-100-percent