Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spellcheck test Templatization #3995

Merged
merged 6 commits into from
Aug 18, 2020
Merged

Spellcheck test Templatization #3995

merged 6 commits into from
Aug 18, 2020

Conversation

areeshatariq
Copy link
Contributor

Description:

HTML Templatization of spellcheck_test.pl using Template::Toolkit

Related issues and discussion: #2416

@areeshatariq areeshatariq added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Aug 5, 2020
@teolemon teolemon requested a review from a team August 8, 2020 15:55
hangy
hangy approved these changes Aug 15, 2020
View reviewed changes
Copy link
Member

@hangy hangy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually didn't know this page existed. 😂 Works well, though!

templates/spellcheck_test.tt.html Outdated Show resolved Hide resolved
VaiTon
VaiTon reviewed Aug 16, 2020
View reviewed changes
templates/spellcheck_test.tt.html Outdated Show resolved Hide resolved
templates/spellcheck_test.tt.html Outdated Show resolved Hide resolved
templates/spellcheck_test.tt.html Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

stephanegigandet
stephanegigandet approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 5ab32c0 into openfoodfacts:master Aug 18, 2020
@teolemon teolemon mentioned this pull request Aug 21, 2021
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaiTon VaiTon VaiTon left review comments

@stephanegigandet stephanegigandet stephanegigandet approved these changes

@hangy hangy hangy approved these changes

Assignees
No one assigned
Labels
Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@areeshatariq @hangy @stephanegigandet @VaiTon