Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Translators using Template::Toolkit #3985

Merged
merged 4 commits into from
Aug 5, 2020

Conversation

areeshatariq
Copy link
Contributor

@areeshatariq areeshatariq commented Aug 4, 2020

Description:

HTML Templatization of top_translators.pl using Template::Toolkit.
Made $tt an exported variable so that we don't need to initialize it in every file and to avoid code redundancy.

Related issues and discussion: #2416

@areeshatariq areeshatariq added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Aug 4, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
34.9% 34.9% Duplication

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!
@hangy : ok for you?

Copy link
Member

@hangy hangy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teolemon
Copy link
Member

teolemon commented Aug 5, 2020

Merging. Thanks @areeshatariq :-)

@teolemon teolemon merged commit 1e31328 into openfoodfacts:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants