Search Form Template #3976
Merged
Search Form Template #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Search Form WIP * popup_menu wip * Search Form Templatization * Removed commented code
teolemon
added
the
Template::Toolkit
templates/search_form.tt.html
Outdated
| <select name="tagtype_${type.id}" id="tagtype_${type.id}"> | ||
| [% FOREACH value IN type.type_arrays %] | ||
| [% IF value.type_labels == 'choose a criterion...' %] | ||
| <option value="[% value.type_values %]" label="[% value.type_labels %]" selected="selected"></option> |
There was a problem hiding this comment.
The selected value is not necessarily the first one. You probably need to compare value.type_value to the type_value variable you are also passing:
push @{$template_data_ref->{criteria}}, {
id => $i,
type_value => $search_tags[$i][0],
type_arrays => \@type_array,
contain_value => $search_tags[$i][1],
contain_array => \@contains,
input_value => $search_tags[$i][2],
};
Maybe to make it clearer:
- type_value could be renamed to selected_type_value
- type_arrays could be renamed to type_options, with inside the array of { value => .. , label => .. }
Same for the other parts of the form below.
There was a problem hiding this comment.
Alright. I'll fix this
|
Kudos, SonarCloud Quality Gate passed!
|
stephanegigandet
approved these changes
Aug 5, 2020
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
HTML Templatization of Search form using Template::Toolkit
Related issues and discussion: #2416