User Form Templatization #3897
Merged
User Form Templatization #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areeshatariq
added
the
Template::Toolkit
hangy
approved these changes
Jul 20, 2020
| @@ -38,9 +38,28 @@ | |||
| use Storable qw/dclone/; | |||
| use Log::Any qw($log); | |||
|
|
|||
| use Template; | |||
| use Data::Dumper; | |||
| my $type = param('type') || 'add'; | ||
| my $action = param('action') || 'display'; | ||
|
|
||
|
|
||
| # Initialize the Template module | ||
| my $tt = Template->new({ |
There was a problem hiding this comment.
I noticed that the initialisation of $tt and $template_data_ref is now done several times in Display.pm and some .pl files in the same way. Would it make sense to introduce a new ProductOpener::Template module with methods that know how to do just that? It could reduce duplicated code and avoid errors.
There was a problem hiding this comment.
@hangy : maybe we can just make the $tt in Display.pm an exported variable. Then it's initialize once at module startup, and that's it.
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
HTML Templatization of User form using Template::Toolkit
Related issues and discussion: #2416