Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display_new() templatization #3845

Merged

Conversation

areeshatariq
Copy link
Contributor

Description:

HTML Templatization of display_new() using Template::Toolkit
A template has been created for pages structure: header, footer, column

Related issues and discussion: #2416

@teolemon teolemon added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Jul 14, 2020
@teolemon teolemon requested a review from a team July 15, 2020 19:08
templates/display_new.tt.html Outdated Show resolved Hide resolved
lib/ProductOpener/Display.pm Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

templates/display_new.tt.html Show resolved Hide resolved
@hangy hangy mentioned this pull request Aug 15, 2020
@stephanegigandet stephanegigandet merged commit a29f497 into openfoodfacts:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants