fix: Missing Template Error: Update ecoscore_details.tt.html to environmental_score_details.tt.html

[JagjeevanAK]

What

This PR updates references to ecoscore_details.tt.html, which was renamed as part of an earlier commit #11142, to the new file name environmental_score_details.tt.html.

Issue Fixed

The website was displaying an error on this page: https://world.openfoodfacts.org/cgi/product_image.pl?code=8033028910213&id=front_en

file error - web/pages/product/includes/environmental_score_details.tt.html: not found

This happened because:

• The ecoscore_details.tt.html template was renamed to environmental_score_details.tt.html as part of the Eco-Score transition.
• Some parts of the code (Perl controllers, config files, or dynamic includes) were still trying to reference the old filename.

Changes Made

• Updated all occurrences of ecoscore_details.tt.html to environmental_score_details.tt.html in:
  • Template files (.tt.html)
• Also checked below file for occurrences of ecoscore_details.tt.html but there was no such thing present,.
  • Perl controllers (.pm)
  • Configurations (.conf, .json, .yml, etc.)
• Verified that the [% INCLUDE ... %] statements correctly reference the new template.
• Restarted the web server locally to confirm the fix.

Feature required changes

• If any frontend dependencies reference ecoscore_details.tt.html, they may need updates as well.
• This PR does not rename database fields or API endpoints—only the template reference.

---

This should be good for submission! Let me know if you need refinements. 🚀

``

Screenshot

Original

Updated change

Related issue(s) and discussion

#11142: Rename Eco-Score fields to Environmental Score

I above issue there was about renaming of ecoscore to environmental_score by stephanegigandet but file names in templates was not made.

• Fixes #11277

If there is an issue in my Pull request then I am open to make necessary changes to it.

[stephanegigandet]

Thank you!

[teolemon]

@stephanegigandet is there a way to check globally for missing includes in templates ? Wouldn't that be a great test to write ?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.86%. Comparing base (3c5ec4a) to head (5a41893).
Report is 13 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11505   +/-   ##
=======================================
  Coverage   49.85%   49.86%           
=======================================
  Files          83       83           
  Lines       22964    22964           
  Branches     5501     5501           
=======================================
+ Hits        11449    11450    +1     
  Misses      10121    10121           
+ Partials     1394     1393    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[JagjeevanAK]

Can anyone help me to know why was this job failed ?? I am seeing there was the issue of cache issue ??. @alexgarel

[stephanegigandet]

Can anyone help me to know why was this job failed ?? I am seeing there was the issue of cache issue ??. @alexgarel

@JagjeevanAK you can look at the details of the failed test, and in the log search for "fail":

https://github.com/openfoodfacts/openfoodfacts-server/actions/runs/13636572520/job/38119624091?pr=11505#step:8:24537

This is because your PR changes the HTML output on some pages (which in this case is a good thing: it removes the error message).

You can run "make update_tests_results" to update the tests results locally.

or /update_tests_results in a GitHub comment

[stephanegigandet]

/update_tests_results

[alexgarel]

@stephanegigandet /update_tests_results does not work when this is a PR from a forked repository…
Maybe because it's @JagjeevanAK who needs to issue it ?

[JagjeevanAK]

/update_tests_results does not work for PRs from forked repositories. Since this PR is from my fork, I need to manually update the test results. I'll run make update_tests_results locally and push the changes.

[JagjeevanAK]

remove this file change it was by mistake. which has already been committed in other PR.

[JagjeevanAK]

Still having issue don't how to overcome it will look at the logs.

[stephanegigandet]

For some reason the port is different:

(  DIAG  )  job  9    | PATH                 | GOT                  | OP | CHECK                |
(  DIAG  )  job  9    +----------------------+----------------------+----+----------------------+
(  DIAG  )  job  9    | {data_quality_errors | http://static.openfo/ | eq | http://static.openfo/ |
(  DIAG  )  job  9    | }{title_element}{ico | odfacts.localhost/im |    | odfacts.localhost:80 |
(  DIAG  )  job  9    | n_url}               | ages/icons/dist/data |    | 80/images/icons/dist |
(  DIAG  )  job  9    |                      | -error.svg           |    | /data-error.svg

[stephanegigandet]

@JagjeevanAK did you do something specific to change the port from 80 to 8080? or maybe it's done on MacOS

[JagjeevanAK]

Sir, It was just for my convenience should I re run the test and push again with port 80 ?

[JagjeevanAK]

@stephanegigandet can you help me to resolve this failed test issue ?

[sonarqubecloud]

Quality Gate failed

Failed conditions
14.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud