Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add test for po/common/common.pot string count #10954

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Oct 30, 2024

Add a test to check the number of strings in po/common/common.pot against po/common/en.po and po/common/fr.po.

  • Create a new test file t/po_common.t
  • Define a function to count the number of strings in a .po or .pot file
  • Count the number of strings in po/common/common.pot, po/common/en.po, and po/common/fr.po
  • Compare the number of strings in po/common/common.pot with po/common/en.po and po/common/fr.po and assert they are equal

For more details, open the Copilot Workspace session.

Related to #10782

Improve log readability and management in `scripts/taxonomies/build_tags_taxonomy.pl`.

* Add `::group::` and `::endgroup::` commands to group log lines by topic.
* Add `::error::` commands to trigger error events when errors occur during taxonomy building.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/openfoodfacts/openfoodfacts-server/issues/10782?shareId=XXXX-XXXX-XXXX-XXXX).
Add a test to check the number of strings in `po/common/common.pot` against `po/common/en.po` and `po/common/fr.po`.

* Create a new test file `t/po_common.t`
* Define a function to count the number of strings in a .po or .pot file
* Count the number of strings in `po/common/common.pot`, `po/common/en.po`, and `po/common/fr.po`
* Compare the number of strings in `po/common/common.pot` with `po/common/en.po` and `po/common/fr.po` and assert they are equal

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/openfoodfacts/openfoodfacts-server?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

sonarcloud bot commented Oct 30, 2024

@alexgarel alexgarel changed the title Add test for po/common/common.pot string count ci: Add test for po/common/common.pot string count Nov 5, 2024
@alexgarel
Copy link
Member

@teolemon

  1. you should merge it against main, not your other branch
  2. you should add your script in the makefile in checks

@teolemon teolemon changed the base branch from teolemon/improve-logs to main November 5, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants