Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality facet - ingredient % over 100 #2168

Closed
Tracked by #10273
teolemon opened this issue Aug 13, 2019 · 5 comments · Fixed by #8094
Closed
Tracked by #10273

Quality facet - ingredient % over 100 #2168

teolemon opened this issue Aug 13, 2019 · 5 comments · Fixed by #8094
Assignees
@matheus-de
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality https://wiki.openfoodfacts.org/Quality Hacktoberfest 🥗 Ingredients Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org Perl Related to the Perl code of the ProductOpener server ⭐ 🐛 top bug Top bug.

Comments

@teolemon
Copy link
Member

teolemon commented Aug 13, 2019 •
edited
Loading

What

Purée 404% (pomme de terre 20,5%, carotte 141%, eau, crème fratche (lait), sel, fibres de lin), eau, boulettes de viande bovine cutes 228% (viande bovine (Oriqine France), eau, fécule de tapioca, sel), tomate 116%, échalotes, fibres de lin, huile de colza, concentré de tomate, sel.

Anything over 100% should be flagged as it is an OCR error.

Code pointer

lib/ProductOpener/DataQuality*.pm

Part of
@teolemon teolemon added 🐛 bug This is a bug, not a feature request. 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data labels Aug 13, 2019
@stephanegigandet
Copy link
Contributor

relevant file: lib/Producers/SiteQuality_off.pm

@manwar
Copy link

manwar commented Oct 3, 2019

relevant file: lib/Producers/SiteQuality_off.pm

You mean lib/ProductOpener/SiteQuality_off.pm ?

@stephanegigandet
Copy link
Contributor

@manwar yes, thank you

@teolemon teolemon added the Perl Related to the Perl code of the ProductOpener server label Oct 10, 2019
@stephanegigandet stephanegigandet added the Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org label Mar 25, 2020
@matheus-de
Copy link

Will work on this issue

@stephanegigandet
Copy link
Contributor

@matheus-de : the relevant files are now lib/ProductOpener/DataQuality*.pm

@teolemon teolemon mentioned this issue Aug 23, 2021
Open
@teolemon teolemon changed the title Add quality facet for ingredient % over 100 Quality facet - ingredient % over 100 Oct 11, 2021
@github-actions github-actions bot added the ⭐ 🐛 top bug Top bug. label Nov 19, 2022
@github-actions github-actions bot mentioned this issue Nov 19, 2022
Open
@benbenben2 benbenben2 mentioned this issue Feb 11, 2023
Merged
@CharlesNepote CharlesNepote added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Feb 15, 2023
@teolemon teolemon mentioned this issue May 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matheus-de matheus-de

Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality https://wiki.openfoodfacts.org/Quality Hacktoberfest 🥗 Ingredients Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org Perl Related to the Perl code of the ProductOpener server ⭐ 🐛 top bug Top bug.
Projects
🍊 Open Food Facts Server issues
Archived in project
🧽 Ensuring Data Quality
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add quality facet ingredient percent over hundred openfoodfacts/openfoodfacts-server
5 participants
@CharlesNepote @manwar @teolemon @stephanegigandet @matheus-de