test: remove scheme in saved html (#10099)

* test: remove scheme in saved html --------- Co-authored-by: Stéphane Gigandet <[email protected]>
openfoodfacts · Apr 8, 2024 · bdc0168 · bdc0168
1 parent d741bcc
commit bdc0168
Show file tree

Hide file tree

Showing 52 changed files with 3,299 additions and 3,293 deletions.
diff --git a/lib/ProductOpener/Test.pm b/lib/ProductOpener/Test.pm
@@ -831,6 +831,8 @@ Normalize the HTML of a web page to be able to compare them across tests runs.
 
 We remove time dependent fields.
 
+We also normalize URLS to avoid the scheme prefix (so that we avoid false positives in CodeQL)
+
 =head3 Arguments
 
 =head4 product_ref - Hash ref containing product information
@@ -847,6 +849,9 @@ sub normalize_html_for_test_comparison ($html_ref) {
 	# <time datetime="2024-03-26T18:43:45">26 mars 2024, 18:43:45 CET</time>
 	$$html_ref =~ s/<time datetime="[^"]+">[^<]+<\/time>/<time datetime="--ignore--">--ignore--<\/time>/g;
 
+	# normalize URLs be removing scheme to avoid false positive alerts on security
+	$$html_ref =~ s/https?:\/\//\/\//g;
+
 	return;
 }
 

diff --git a/stop_words.txt b/stop_words.txt
@@ -49,6 +49,7 @@ Ciqual
 CIQUAL
 citrique
 CodeOnline
+CodeQL
 colza
 Config
 contenant

diff --git a/tests/integration/expected_test_results/api_v2_product_read/get-auth-bad-user-password.html b/tests/integration/expected_test_results/api_v2_product_read/get-auth-bad-user-password.html
diff --git a/...ation/expected_test_results/api_v2_product_write/post-product-auth-bad-user-password.html b/...ation/expected_test_results/api_v2_product_write/post-product-auth-bad-user-password.html
diff --git a/tests/integration/expected_test_results/page_crawler/crawler-access-category-facet-page.html b/tests/integration/expected_test_results/page_crawler/crawler-access-category-facet-page.html
diff --git a/tests/integration/expected_test_results/page_crawler/crawler-access-product-page.html b/tests/integration/expected_test_results/page_crawler/crawler-access-product-page.html
diff --git a/...ation/expected_test_results/page_crawler/crawler-does-not-get-facet-knowledge-panels.html b/...ation/expected_test_results/page_crawler/crawler-does-not-get-facet-knowledge-panels.html
diff --git a/...ntegration/expected_test_results/page_crawler/normal-user-access-category-facet-page.html b/...ntegration/expected_test_results/page_crawler/normal-user-access-category-facet-page.html
diff --git a/.../integration/expected_test_results/page_crawler/normal-user-access-editor-facet-page.html b/.../integration/expected_test_results/page_crawler/normal-user-access-editor-facet-page.html
diff --git a/tests/integration/expected_test_results/page_crawler/normal-user-access-list-of-tags.html b/tests/integration/expected_test_results/page_crawler/normal-user-access-list-of-tags.html
diff --git a/.../integration/expected_test_results/page_crawler/normal-user-access-nested-facet-page.html b/.../integration/expected_test_results/page_crawler/normal-user-access-nested-facet-page.html
diff --git a/tests/integration/expected_test_results/page_crawler/normal-user-access-product-page.html b/tests/integration/expected_test_results/page_crawler/normal-user-access-product-page.html
diff --git a/...ntegration/expected_test_results/page_crawler/normal-user-get-facet-knowledge-panels.html b/...ntegration/expected_test_results/page_crawler/normal-user-get-facet-knowledge-panels.html
diff --git a/tests/integration/expected_test_results/page_crawler/normal-user-get-non-official-cc-lc.html b/tests/integration/expected_test_results/page_crawler/normal-user-get-non-official-cc-lc.html
diff --git a/tests/integration/expected_test_results/product_read/get-existing-product.html b/tests/integration/expected_test_results/product_read/get-existing-product.html
diff --git a/tests/integration/expected_test_results/product_read/get-unexisting-product.html b/tests/integration/expected_test_results/product_read/get-unexisting-product.html
diff --git a/...on/expected_test_results/protected_product/edit-protected-product-web-form-moderator.html b/...on/expected_test_results/protected_product/edit-protected-product-web-form-moderator.html
diff --git a/.../integration/expected_test_results/protected_product/edit-protected-product-web-form.html b/.../integration/expected_test_results/protected_product/edit-protected-product-web-form.html
diff --git a/...ntegration/expected_test_results/protected_product/edit-unprotected-product-web-form.html b/...ntegration/expected_test_results/protected_product/edit-unprotected-product-web-form.html
diff --git a/tests/integration/expected_test_results/unknown_tags/country-cambodia-exists-but-empty.html b/tests/integration/expected_test_results/unknown_tags/country-cambodia-exists-but-empty.html
diff --git a/...ntegration/expected_test_results/unknown_tags/country-doesnotexist-ingredients-apple.html b/...ntegration/expected_test_results/unknown_tags/country-doesnotexist-ingredients-apple.html
diff --git a/tests/integration/expected_test_results/unknown_tags/country-doesnotexist-ingredients.html b/tests/integration/expected_test_results/unknown_tags/country-doesnotexist-ingredients.html
diff --git a/tests/integration/expected_test_results/unknown_tags/country-doesnotexist.html b/tests/integration/expected_test_results/unknown_tags/country-doesnotexist.html
diff --git a/tests/integration/expected_test_results/unknown_tags/country-france-exists.html b/tests/integration/expected_test_results/unknown_tags/country-france-exists.html
diff --git a/tests/integration/expected_test_results/unknown_tags/ingredient-apple-exists.html b/tests/integration/expected_test_results/unknown_tags/ingredient-apple-exists.html
diff --git a/...sults/unknown_tags/ingredient-someunknownandemptyingredient-does-not-exist-and-empty.html b/...sults/unknown_tags/ingredient-someunknownandemptyingredient-does-not-exist-and-empty.html
diff --git a/...ts/unknown_tags/ingredient-someunknowningredient-does-not-exist-but-not-empty-labels.html b/...ts/unknown_tags/ingredient-someunknowningredient-does-not-exist-but-not-empty-labels.html
diff --git a/...t_results/unknown_tags/ingredient-someunknowningredient-does-not-exist-but-not-empty.html b/...t_results/unknown_tags/ingredient-someunknowningredient-does-not-exist-but-not-empty.html
diff --git a/tests/integration/expected_test_results/unknown_tags/unknown-product.html b/tests/integration/expected_test_results/unknown_tags/unknown-product.html
diff --git a/tests/integration/expected_test_results/web_html/fr-brands.html b/tests/integration/expected_test_results/web_html/fr-brands.html
diff --git a/tests/integration/expected_test_results/web_html/fr-categories.html b/tests/integration/expected_test_results/web_html/fr-categories.html
diff --git a/tests/integration/expected_test_results/web_html/fr-countries.html b/tests/integration/expected_test_results/web_html/fr-countries.html
diff --git a/tests/integration/expected_test_results/web_html/fr-edit-product.html b/tests/integration/expected_test_results/web_html/fr-edit-product.html
diff --git a/tests/integration/expected_test_results/web_html/fr-index.html b/tests/integration/expected_test_results/web_html/fr-index.html
diff --git a/tests/integration/expected_test_results/web_html/fr-labels.html b/tests/integration/expected_test_results/web_html/fr-labels.html
diff --git a/tests/integration/expected_test_results/web_html/fr-product-2.html b/tests/integration/expected_test_results/web_html/fr-product-2.html
diff --git a/tests/integration/expected_test_results/web_html/fr-product.html b/tests/integration/expected_test_results/web_html/fr-product.html
diff --git a/tests/integration/expected_test_results/web_html/fr-search-form.html b/tests/integration/expected_test_results/web_html/fr-search-form.html
diff --git a/tests/integration/expected_test_results/web_html/fr-search-results.html b/tests/integration/expected_test_results/web_html/fr-search-results.html
diff --git a/tests/integration/expected_test_results/web_html/user-register.html b/tests/integration/expected_test_results/web_html/user-register.html
diff --git a/tests/integration/expected_test_results/web_html/world-brands.html b/tests/integration/expected_test_results/web_html/world-brands.html
diff --git a/tests/integration/expected_test_results/web_html/world-categories.html b/tests/integration/expected_test_results/web_html/world-categories.html
diff --git a/tests/integration/expected_test_results/web_html/world-countries.html b/tests/integration/expected_test_results/web_html/world-countries.html
diff --git a/tests/integration/expected_test_results/web_html/world-edit-product.html b/tests/integration/expected_test_results/web_html/world-edit-product.html
diff --git a/tests/integration/expected_test_results/web_html/world-index-signedin.html b/tests/integration/expected_test_results/web_html/world-index-signedin.html
diff --git a/tests/integration/expected_test_results/web_html/world-index.html b/tests/integration/expected_test_results/web_html/world-index.html
diff --git a/tests/integration/expected_test_results/web_html/world-label-organic.html b/tests/integration/expected_test_results/web_html/world-label-organic.html
diff --git a/tests/integration/expected_test_results/web_html/world-labels.html b/tests/integration/expected_test_results/web_html/world-labels.html
diff --git a/tests/integration/expected_test_results/web_html/world-product-not-found.html b/tests/integration/expected_test_results/web_html/world-product-not-found.html
diff --git a/tests/integration/expected_test_results/web_html/world-product.html b/tests/integration/expected_test_results/web_html/world-product.html
diff --git a/tests/integration/expected_test_results/web_html/world-search-form.html b/tests/integration/expected_test_results/web_html/world-search-form.html
diff --git a/tests/integration/expected_test_results/web_html/world-search-results.html b/tests/integration/expected_test_results/web_html/world-search-results.html
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,6 +49,7 @@ Ciqual @@
     CIQUAL
     citrique
     CodeOnline
+    CodeQL
     colza
     Config
     contenant
@@ Expand Down @@