fix: "Barcode limit: 13 digits or more?"

[aadarsh-ram]

What

• Folksonomy Engine recognizes products with 1-13 digit barcodes (regexp: [0-9]{1,13}) only.
• As Folksonomy Engine can be used for other types of products, it must recognize barcodes with more than 13 digits.
• This pull request aims to fix the above issue, as well as some other extra bugs found during testing.

Related issue(s)

• Fixes barcode limit: 13 digits or more? #49
• No checks done for empty product barcode.

File additions/deletions

• Added a folder for database migration scripts. This folder can be used for future migration scripts as well.
• Added a main migration script and a migration step file. Data migration is done using yoyo-migrations which has been added to the dependencies of Folksonomy Engine.
• Added provisions for mentioning PostgresSQL user and host in local_settings_example.py
• Changed regexp to check for barcodes with greater than 13 digits.
• Changed table definitions of folksonomy and folksonomy_versions to include product barcodes of greater than 13 digits.
• A barcode limit of 24 digits has been established after discussion.
• Added a test with a barcode of 25 digits.
• Removed the test which checks for greater than 14 digits barcodes.
• Updated documentation

Part of

• 🎯 What can I work on ? (Folksonomy Engine) #70

All unit tests which are part of test_main.py have passed.
Please do provide feedback after reviewing this PR. I hope that I will contribute more to OpenFoodFacts!

[alexgarel]

LGTM, but I would like @CharlesNepote or @cquest to give their opinion.

[alexgarel]

I added some remarks.

See in particular my comment for local_settings.py if it's not clear I may explain better.

[alexgarel]

@aadarsh-ram : to finish this request, I would say: just add a limit to barcode (32 is good I think).

[alexgarel]

Sorry @aadarsh-ram still small comments, but we are very near the end !

[alexgarel]

Kudos @aadarsh-ram, good work.

[CharlesNepote]

@aadarsh-ram @alexgarel : what should be the upgrade process then?
I started to document it here: https://github.com/openfoodfacts/openfoodfacts-infrastructure/blob/develop/docs/folksonomy.md#upgrade

But I guess I need to run a script for the DB migration?

[CharlesNepote]

@aadarsh-ram I added the https://github.com/openfoodfacts/folksonomy_api/blob/main/yoyo.ini file and wrote the upgrade documentation for our infrastructure: https://github.com/openfoodfacts/openfoodfacts-infrastructure/blob/develop/docs/folksonomy.md#upgrade

[aadarsh-ram]

@aadarsh-ram I added the https://github.com/openfoodfacts/folksonomy_api/blob/main/yoyo.ini file and wrote the upgrade documentation for our infrastructure: https://github.com/openfoodfacts/openfoodfacts-infrastructure/blob/develop/docs/folksonomy.md#upgrade

LGTM. FYI, you can use the command line interface or use the db_migrations.py script after setting the local_settings.py file.