Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ajout de l'aide au permis des yvelines #186

Merged
merged 3 commits into from
Dec 4, 2023
Merged

feat: ajout de l'aide au permis des yvelines #186

merged 3 commits into from
Dec 4, 2023

Conversation

baptou12
Copy link
Contributor

@Shamzic Shamzic force-pushed the 1469-ajouter-laide-au-permis-de-conduire-du-departement-des-yvelines branch from e7a0470 to a824e59 Compare November 22, 2023 10:49
Shamzic
Shamzic previously requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@Shamzic Shamzic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une remarque sur le nommage des variables et quelques questions/doutes sur les specs.

Y a aussi un problème de numéro de version car je crois que ça date un peu, le setup.py et le changelog.md doivent être modifiés (me suis permis de rebase)

openfisca_france_local/departements/yvelines/aide_permis.py Outdated Show resolved Hide resolved
openfisca_france_local/departements/yvelines/aide_permis.py Outdated Show resolved Hide resolved
openfisca_france_local/parameters/departements/yvelines/aide_permis.yml Show resolved Hide resolved
openfisca_france_local/departements/yvelines/aide_permis.py Outdated Show resolved Hide resolved
@Shamzic Shamzic mentioned this pull request Nov 24, 2023
Merged
@Allan-CodeWorks Allan-CodeWorks self-assigned this Nov 27, 2023
@Allan-CodeWorks Allan-CodeWorks force-pushed the 1469-ajouter-laide-au-permis-de-conduire-du-departement-des-yvelines branch from a824e59 to 8350861 Compare November 27, 2023 13:29
@Allan-CodeWorks Allan-CodeWorks force-pushed the 1469-ajouter-laide-au-permis-de-conduire-du-departement-des-yvelines branch from 8350861 to 83491e9 Compare November 27, 2023 13:34
@Allan-CodeWorks Allan-CodeWorks requested review from Shamzic and a team November 28, 2023 13:37
baptou12
baptou12 commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@baptou12 baptou12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me semble good et même mieux (je peux pas approve). Mais toujours la gestion de rgb qui va falloir réglé dans aides-jeunes

Allan-CodeWorks
Allan-CodeWorks approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Allan-CodeWorks Allan-CodeWorks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travail conjoint et suite au commentaire de Baptiste je merge

@Allan-CodeWorks Allan-CodeWorks dismissed Shamzic’s stale review December 4, 2023 08:47

La remarque a été adressée

@Allan-CodeWorks Allan-CodeWorks merged commit 2992791 into master Dec 4, 2023
9 checks passed
@Allan-CodeWorks Allan-CodeWorks deleted the 1469-ajouter-laide-au-permis-de-conduire-du-departement-des-yvelines branch December 4, 2023 08:48
@guillett guillett added this to the Passé milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Allan-CodeWorks Allan-CodeWorks Allan-CodeWorks approved these changes

@Shamzic Shamzic Awaiting requested review from Shamzic

Assignees

@Allan-CodeWorks Allan-CodeWorks

Labels
None yet
Projects
None yet
Milestone
Passé
Development

Successfully merging this pull request may close these issues.
4 participants
@baptou12 @Shamzic @Allan-CodeWorks @guillett