Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove subprojects build config, add group and version #40

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: remove subprojects build config, add group and version #40

merged 1 commit into from
Apr 9, 2024

Conversation

jimmyjames
Copy link
Collaborator

@jimmyjames jimmyjames commented Apr 9, 2024 •
edited
Loading

Remove subprojects configuration.

Description

Missed from #39. Also added groupId and version in build file (may be needed for GH package publish).

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jimmyjames jimmyjames requested a review from a team as a code owner April 9, 2024 20:15
@jimmyjames jimmyjames added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit f256b3a Apr 9, 2024
14 checks passed
@jimmyjames jimmyjames deleted the fix-build branch April 9, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyjames @rhamzeh