Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add spotless plugin #16

Merged
merged 3 commits into from
Mar 6, 2024
Merged

chore: add spotless plugin #16

merged 3 commits into from
Mar 6, 2024

Conversation

jimmyjames
Copy link
Collaborator

@jimmyjames jimmyjames commented Mar 6, 2024 •
edited
Loading

Description

Adds the Gradle spotless plugin.

📝 There are no functional changes to any code in this PR 📝

  • Configured the same as the FGA Java SDK
  • spotlessCheck task is dependent on check; check will fail if spotless check fails
  • Run fmt to apply spotless formatting

Changes to source files are result of running ./gradlew fmt. Future builds with spotless violations will fail.

References

Closes #14

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jimmyjames jimmyjames requested a review from a team as a code owner March 6, 2024 19:30
evansims
evansims approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful-jake-gif

@jimmyjames jimmyjames added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit ac2933d Mar 6, 2024
4 checks passed
@jimmyjames jimmyjames deleted the add-spotless branch March 6, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Spotless gradle plugin for syntax consistency/linting
2 participants
@jimmyjames @evansims