-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial OpenFgaClientConfig #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
commented
Mar 5, 2024
jimmyjames
commented
Mar 5, 2024
jimmyjames
commented
Mar 5, 2024
src/main/java/dev/openfga/autoconfigure/OpenFgaAutoConfiguration.java
Outdated
Show resolved
Hide resolved
rhamzeh
reviewed
Mar 5, 2024
rhamzeh
reviewed
Mar 5, 2024
rhamzeh
reviewed
Mar 5, 2024
src/test/java/dev/openfga/autoconfigure/FgaAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
rhamzeh
approved these changes
Mar 6, 2024
Q: We are copying the enum and validation here, any chance we can reuse what's in the SDK? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for autoconfiguration of an
OpenFgaClient
.Description
Creates an
openFgaClient
bean from configuration.Not all configurations available via Configuration are added in this PR (e.g.,
maxRetries
, timeouts). We can capture another issue to see what other configurations should be surfaced here.I also added some very brief info to the README; obviously will need more work, but wanted to capture some of the details.
Some details about how the
OpenFgaClient
is configured given property values:credentials
properties are specified, no credentials (no authorization) is configured for the clientcredentials.api-token
property is specified, that (and only that) will be used to configure the clientcredentials
properties are specifed, they will be used to configure the clientCloses #2
References
https://github.com/openfga/java-sdk/tree/main?tab=readme-ov-file#initializing-the-api-client
Review Checklist
main