Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect response in Gdrive modelling guide #786

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

sujitha-av
Copy link
Contributor

Description

Erik is mentioned in text to be a allowed viewer of the document when describing 'type bound public access' in Google Drive. But the code snippet says false. Took me some time to figure out.

References

The relevant text in the documentation.

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main

Erik is mentioned in text to be a allowed viewer of the document when describing 'type bound public access' in Google Drive. But the code snippet says false. Took me some time to figure out.
@sujitha-av sujitha-av requested a review from a team as a code owner July 2, 2024 15:37
Copy link

linux-foundation-easycla bot commented Jul 2, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rhamzeh rhamzeh enabled auto-merge (squash) July 3, 2024 12:07
@rhamzeh rhamzeh changed the title Fix: Error in Gdrive modelling guide fix: fix incorrect response in Gdrive modelling guide Jul 3, 2024
@rhamzeh rhamzeh merged commit c89f494 into openfga:main Jul 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants