Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove excluded users from ListUsers response #87

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

ewanharris
Copy link
Member

Description

Removes excluded_users from the response of all SDKs as it was removed from OpenFGA with openfga/api#171.

This feature was originally a well-intentioned way to communicate any negations that may exist on public-typed wildcard (e.g. user:*) as a means of being abundantly clear about what a user:* result entails. However, as we discover more possible situations where excluded users could arise, we realize that we were making a premature decision about the API. We fully intend to re-add excluded_users at some point in the future but may or may not be a flattened list as previously implemented.

Please note:

  • This is technically a breaking but is acceptable provided that the ListUsers API is still experimental

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners June 14, 2024 10:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.72%. Comparing base (f36e6e2) to head (7b23edd).

Files Patch % Lines
...a/dev/openfga/sdk/api/model/ListUsersResponse.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #87      +/-   ##
============================================
+ Coverage     27.49%   27.72%   +0.22%     
+ Complexity      787      785       -2     
============================================
  Files           159      158       -1     
  Lines          5928     5862      -66     
  Branches        651      639      -12     
============================================
- Hits           1630     1625       -5     
+ Misses         4222     4161      -61     
  Partials         76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 1ff6471 Jun 14, 2024
19 checks passed
@ewanharris ewanharris deleted the chore/excluded-users-removal branch June 14, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants