Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): Allow extension of test pod to allow matching local policy #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grimly
Copy link

@grimly grimly commented Jan 3, 2025

Provides the ability to extends the definition of the connection test pod.

Description

The helm chart uses a pod to test its correct deployment.
There is no ability to extend the definition of this pod and therefore to make the pod match any policy in place.

Such policy preventing the test pod deployment might be (not exhaustive):

  • Resource quota without ability to provide a default value with a limit range
  • ValidatingWebhookConfiguration based constraints with products such as kyverno or OPA

Here is a working example of a configuration matching the resource quota constraint :

testContainerSpec:
  resources:
    limits:
      cpu: 1
      memory: 250M
    requests:
      cpu: 50m
      memory: 250M
testPodSpec:
  securityContext:
    runAsNonRoot: true
    runAsUser: 1000
    runAsGroup: 1000

References

This feature is documented by the value schemas.

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@grimly grimly requested review from a team as code owners January 3, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant