Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing excluded users from ListUsers response #108

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

willvedd
Copy link
Contributor

Description

Removes excluded_users from the response of all SDKs as it was removed from OpenFGA with openfga/api#171.

This feature was originally a well-intentioned way to communicate any negations that may exist on public-typed wildcard (e.g. user:*) as a means of being abundantly clear about what a user:* result entails. However, as we discover more possible situations where excluded users could arise, we realize that we were making a premature decision about the API. We fully intend to re-add excluded_users at some point in the future but may or may not be a flattened list as previously implemented.

Please note:

  • This is technically a breaking but is acceptable provided that the ListUsers API is still experimental

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@willvedd willvedd requested review from a team as code owners June 13, 2024 21:25
README.md Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.77%. Comparing base (97c03bc) to head (4ba6e46).

Files Patch % Lines
model_list_users_response.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   23.59%   23.77%   +0.17%     
==========================================
  Files          95       94       -1     
  Lines        9956     9877      -79     
==========================================
- Hits         2349     2348       -1     
+ Misses       7357     7279      -78     
  Partials      250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhamzeh rhamzeh added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 3b7f094 Jun 14, 2024
9 checks passed
@rhamzeh rhamzeh deleted the list-users-remove-excluded-users branch June 14, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants