Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display success/failed tuples import #319

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edwin-Marrima
Copy link
Contributor

Description

Closes #259

  • Enhance store import functionality testability
  • Suppress store object display when store ID is provided in command

References

Review Checklist

  • [ x] I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • [ x] The correct base branch is being used, if not main
  • [ x] I have added tests to validate that the change in functionality is working as expected

@edwin-Marrima edwin-Marrima requested a review from a team as a code owner May 3, 2024 19:20
@ewanharris
Copy link
Member

Hey @edwin-Marrima, thanks for this PR and apologies for our delay in reviewing it.

I think before giving a 👍🏻 or 👎🏻 on this PR we'd like to take a further look at the way you've approached the testing as we currently tend to prefer mocking the FGA Client calls in tests (see an example here) and I'm not sure how the IODependency pattern you've introduced here would expand across the other commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store import should return store_id, model_id, errors if tuples failed to write
2 participants