feat: proto changes for attribute-based access control #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add `condition` to RelationReference * feat: add `Condition` definition * feat: add `conditions` to AuthorizationModel * update swagger * feat: add `conditions` to WriteAuthorizationModelRequest * feat: add `context` fields to query requests * use an enum for condition param type names * add feat branch to review workflow * stick to enum conventions * suppress diffs from generated files * regenerate * add missing type name * proposed validation as starting point * add ipaddress type * tweaks * update validation for Condition.name * refactor: change Assertion TupleKey to CheckRequestTupleKey * feat: adding condition for tuple key (#94) * feat: adding condition for tuple key * remove redundant validation --------- Co-authored-by: Jonathan Whitaker <[email protected]> Co-authored-by: Adrian Tam <[email protected]>
* re-order fields on TupleKey * mark fields as required where applicable
jpadilla
changed the title
24 tasks
4 tasks
Co-authored-by: José Padilla <[email protected]>
) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts: # proto/openfga/v1/openfga_service.pb.go
jon-whit
reviewed
Nov 21, 2023
This was referenced Nov 22, 2023
rhamzeh
previously approved these changes
Dec 1, 2023
fix: mark more fields as required
jon-whit
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce the new API definitions for the official OpenFGA ABAC support along with modifications to the existing API to better align with the ABAC changes.
References
Review Checklist
main