-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store changes filter by start time #204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cikasfm
force-pushed
the
feature/store-changes-filter-by-start-time
branch
from
October 14, 2024 15:33
281b25b
to
23ffb2d
Compare
cikasfm
changed the title
WIP: Store changes filter by start time
Store changes filter by start time
Oct 14, 2024
poovamraj
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor clarification, or else looks good to me. I'd pull in a core member to have an extra pair of eyes.
cikasfm
force-pushed
the
feature/store-changes-filter-by-start-time
branch
from
October 16, 2024 18:07
9d5cebe
to
6cb4c29
Compare
cikasfm
force-pushed
the
feature/store-changes-filter-by-start-time
branch
from
October 23, 2024 23:29
6cb4c29
to
ebd592f
Compare
4 tasks
elbuo8
reviewed
Oct 24, 2024
…long side start_time, the continuation_token will take precedence over start_time.
jpadilla
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a Developer, I want to be able to query the changelog based on a specific time period (start date), so that I can retrieve only the changes made after that specific point in time. This will improve the efficiency of tracking and processing changes for the user.
Why are we doing this? The changelog contains all changes made to resources over time. Providing the ability to filter these changes by a specific time ensures that developers can query only the relevant data, making the API responses lighter, faster and more efficient.
The changelog can be filtered using the start date as an additional parameter in the API, SDKs,and CLI
The start time parameter should be in the ISO 8601 format
Example: YYYY-MM-DDTHH:MM:SSZ (ISO 8601 DateTime)
Description
Added optional
start_time
attribute to/store/{id}/changes
API to allow streaming starting the given time stamp.References
Review Checklist
main