Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unspecified from consistency parameter documentation #186

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimmyjames
Copy link
Contributor

Description

Sets the UNSPECIFIED consistency preference to INTERNAL, which prevents it from being exported as a valid enum value in the swagger.

SDKs can then be generated without requiring any odd manipulation to handle namespace collisions on UNSPECIFIED.

References

https://grpc-ecosystem.github.io/grpc-gateway/docs/mapping/customizing_openapi_output/#hiding-fields-methods-services-and-enum-values

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jimmyjames jimmyjames requested review from a team as code owners August 13, 2024 18:36
@jimmyjames jimmyjames marked this pull request as draft August 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant