feat: add query consistency params #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add consistency enum parameter for query APIs * fix CI workflow branch name * ignore enum suffix lint rule * ignore enum val prefix lint warning * fix up generated files * docs formatting fix * review feedback: update enum vals for future additions, update docs * fix up docs clarification for all endpoints
ewanharris
commented
Jul 16, 2024
rhamzeh
previously approved these changes
Jul 16, 2024
willvedd
reviewed
Jul 16, 2024
willvedd
reviewed
Jul 16, 2024
elbuo8
reviewed
Jul 16, 2024
* doc: correct consistency reference in doc string * chore: remove dx from codeowners as we're moving off feature branch
rhamzeh
previously approved these changes
Jul 18, 2024
4 tasks
jpadilla
previously approved these changes
Jul 23, 2024
ci: don't pin version of buf (#181) * ci: don't pin version of buf Instead we will use the version that correlates to the action version * chore(deps): update buf-setup-action version * style: run buf format to make formatting changes
jpadilla
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the consistency parameter to the following endpoints:
The parameter is an enum with two values:
UNSPECIFIED- This value should not be sent to the API but is the default. Intended to mean value not provided and will implyMINIMIZE_LATENCYbehaviorMINIMIZE_LATENCY- behavior is as-is today, prefer the usage of caching methods to reduce query timeHIGHER_CONSISTENCY- used to signal to the API to prefer higher consistency at the expense of potentially reduced performanceReferences
Review Checklist
main