Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListUsers API protobuf definitions #140

Merged
merged 15 commits into from
Mar 9, 2024
Merged

ListUsers API protobuf definitions #140

merged 15 commits into from
Mar 9, 2024

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Mar 7, 2024 •
edited
Loading

Description

Defining protobufs to facilitate OpenFGA's upcoming ListUsers functionality which answers the question of "what users relate to a specific resource?". The definitions themselves are not final and are subject to change. Please refer to the ListUsers RFC for more specifics about the API's functionality as well as technical changes that can be expected.

Note: This PR is a draft to enable ListUsers development in the main OpenFGA repo.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@willvedd willvedd marked this pull request as ready for review March 8, 2024 19:59
@willvedd willvedd requested review from a team as code owners March 8, 2024 19:59
miparnisari
miparnisari previously approved these changes Mar 8, 2024
View reviewed changes
openfga/v1/openfga_service.proto Outdated Show resolved Hide resolved
@willvedd @miparnisari
Update openfga/v1/openfga_service.proto
c98ffc5 
Co-authored-by: Maria Ines Parnisari <[email protected]>
@willvedd willvedd mentioned this pull request Mar 8, 2024
Merged
4 tasks
@willvedd willvedd merged commit 4255ca2 into main Mar 9, 2024
5 checks passed
@willvedd willvedd deleted the list-users branch March 9, 2024 01:05
willvedd added a commit that referenced this pull request Mar 11, 2024
@willvedd
Revert "ListUsers API protobuf definitions (#140)"
c91128b 
This reverts commit 4255ca2.
@willvedd willvedd restored the list-users branch March 11, 2024 18:04
@willvedd willvedd mentioned this pull request Mar 11, 2024
Merged
4 tasks
miparnisari pushed a commit that referenced this pull request Mar 11, 2024
@willvedd
Revert #140 (#143)
cf9358a 
Revert "`ListUsers` API protobuf definitions (#140)"

This reverts commit 4255ca2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miparnisari miparnisari miparnisari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willvedd @miparnisari