fix: mark more fields as required - add ComputedUserset #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpadilla
approved these changes
Oct 27, 2023
jon-whit
suggested changes
Oct 27, 2023
There was a problem hiding this comment.
Are we following the protobuf best practices here with OUTPUT_ONLY vs REQUIRED fields? I'm not sure we are, and I'd us to verify that we are doing so.
Would you please post some links with best-practice guidance on the usage difference between these different options etc..?
|
@jon-whit feel free to do that change |
rhamzeh
force-pushed
the
fix/more-validations
branch
from
07c5d1c
to
3e43315
Compare
jon-whit
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Review Checklist
main