This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Change the order of checking cert-manager is ready before moving on #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently install cert-manager, then just install openfaas chart
then we check if cert-manager is ready. This leads to openfaas failing
to install because the webhooks for cert-manager don't exist and helm
fails if any of the endpoints are not ready. See issue:
helm/helm#6361
This has been tested by running before changing the code, and openfaas
failed to install. Then I changed the order and ran against a new cluster.
This install worked as expected.
Fixes #178
Fixes #168
Signed-off-by: Alistair Hey [email protected]
How Has This Been Tested?
This has been tested by running before changing the code, and openfaas
failed to install. Then I chnged the order and ran against a new cluster.
Checklist:
I have:
git commit -s