chore: Remove XModuleMixin legacy attributes from xblocks-contrib#128
Closed
chore: Remove XModuleMixin legacy attributes from xblocks-contrib#128
Conversation
kdmccormick
requested changes
Jan 7, 2026
Member
kdmccormick
left a comment
kdmccormick
left a comment
There was a problem hiding this comment.
Nice approach.
Rather than going through .scope_ids, can you use the usage_key and context_key helper attributes defined here? https://github.com/openedx/XBlock/blob/v5.3.0/xblock/core.py#L422-L446 .
The .scope_ids field is technically correct to use, but it's honestly just verbose and hard for developers to understand. The usage_key and context_key were added a couple years ago specifically to make it nicer for developers. My bad for not clarifying that earlier.
I've updated the XModuleMixin and CourseOverview classes to follow the same pattern: openedx/openedx-platform#37845. Do you mind reviewing that PR?
farhan
changed the title
farhan
force-pushed
the
farhan/remove-legacy-xmodule-mixin-attributes
branch
from
22b71fc to
9a0ff81
Compare
farhan
force-pushed
the
farhan/remove-legacy-xmodule-mixin-attributes
branch
from
a5dc6ac to
e78be4e
Compare
Contributor
Author
|
Closing as we have decided to do it in seperate PR's per block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #125
openedx-platformtest cases PRDetails can be found here:
#125 (comment)