fix: only count successful queries

openedx · Dec 18, 2024 · 0300e33 · 0300e33
1 parent b14e855
commit 0300e33
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tutoraspects/templates/aspects/apps/superset/pythonpath/performance_metrics.py b/tutoraspects/templates/aspects/apps/superset/pythonpath/performance_metrics.py
@@ -116,9 +116,9 @@ def performance_metrics(
                     slice, query_contexts, extra_filters
                 )
                 result = measure_chart(slice, query_context, fail_on_error)
-                chart_count += 1
                 if not result:
                     continue
+                chart_count += 1
                 for query in result["queries"]:
                     # Remove the data from the query to avoid memory issues on large
                     # datasets.

diff --git a/...ts/templates/aspects/build/aspects-superset/openedx-assets/assets/datasets/query_log.yaml b/...ts/templates/aspects/build/aspects-superset/openedx-assets/assets/datasets/query_log.yaml
@@ -118,7 +118,7 @@ sql: |
       query,
       http_user_agent
   FROM system.query_log
-  WHERE databases <> ['system'] AND (http_user_agent LIKE 'aspects-%') AND (type <> 'QueryStart')
+  WHERE databases <> ['system'] AND (http_user_agent LIKE 'aspects-%') AND (type = 'QueryFinish')
   ORDER BY event_time DESC
 table_name: query_log
 template_params: null