Skip to content

Conversation

@Ang-m4
Copy link
Contributor

@Ang-m4 Ang-m4 commented Sep 15, 2025

Description

This pull request introduces support for mounting Paragon theme static files into the MFE Kubernetes deployment. The changes ensure that the correct theme CSS files are generated, made available as config maps, and mounted as read-only volumes in the application pods.

Kubernetes config and volume management:

  • Added a paragon-static-files config map generator to kustomization-configmapgenerator for including core and theme CSS files, dynamically supporting multiple themes.
  • Updated mfe-k8s-volumes to create a static-files volume from the generated config map, mapping core and theme CSS files to their respective paths.
  • Modified mfe-k8s-volume-mounts to mount the static-files volume at /paragon-statics as read-only in the MFE containers.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 15, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 15, 2025

Thanks for the pull request, @Ang-m4!

This repository is currently maintained by @arbrandes.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 15, 2025
@Ang-m4 Ang-m4 marked this pull request as ready for review September 15, 2025 17:55
@Ang-m4
Copy link
Contributor Author

Ang-m4 commented Sep 15, 2025

Hi @brian-smith-tcril, @sarina,
Hope you're doing great!

As the last piece of work for completing the Paragon plugin implementation, I’ve just opened this PR with the Kubernetes integration 😊 , now that overhangio/tutor-mfe#267 has been successfully merged.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to match the patterns from the caddy version, so from what I can tell this LGTM.

I'd like to have someone who knows k8s better than I do double check this.

@arbrandes - would you be able to take a quick look?

@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Sep 16, 2025
@sarina sarina added the FC Relates to an Axim Funded Contribution project label Sep 18, 2025
@sarina
Copy link

sarina commented Sep 22, 2025

@arbrandes - can we get your 👀 to finish out this FC?

@sarina sarina requested a review from arbrandes September 22, 2025 15:50
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the actual files that are being mounted, but this looks alright to me, with the exception of a redundant if block.

I did not actually test this on a Tutor k8s deployment, though. @Ang-m4, did you?

@Ang-m4
Copy link
Contributor Author

Ang-m4 commented Sep 22, 2025

@arbrandes, You’re right, I forgot to update the conditionals after adding the same control variable in k8s-deployments. I’ll fix that shortly.

For k8s testing, I set up an environment with Minikube and confirmed that the volumes were mounted correctly for the MFE service. I also verified that the service was serving static files as expected.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the previous comments and confirming this was tested. Looks good!

@arbrandes
Copy link
Contributor

@brian-smith-tcril, I'll let you do the honors.

@brian-smith-tcril brian-smith-tcril merged commit e612e4b into openedx:main Sep 23, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants