-
Notifications
You must be signed in to change notification settings - Fork 11
feat: add k8s integration for tutor paragon static hosting #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add k8s integration for tutor paragon static hosting #45
Conversation
|
Thanks for the pull request, @Ang-m4! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @brian-smith-tcril, @sarina, As the last piece of work for completing the Paragon plugin implementation, I’ve just opened this PR with the Kubernetes integration 😊 , now that overhangio/tutor-mfe#267 has been successfully merged. |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to match the patterns from the caddy version, so from what I can tell this LGTM.
I'd like to have someone who knows k8s better than I do double check this.
@arbrandes - would you be able to take a quick look?
|
@arbrandes - can we get your 👀 to finish out this FC? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't speak to the actual files that are being mounted, but this looks alright to me, with the exception of a redundant if block.
I did not actually test this on a Tutor k8s deployment, though. @Ang-m4, did you?
plugins/tutor-contrib-paragon/tutorparagon/patches/mfe-k8s-volumes
Outdated
Show resolved
Hide resolved
|
@arbrandes, You’re right, I forgot to update the conditionals after adding the same control variable in For k8s testing, I set up an environment with Minikube and confirmed that the volumes were mounted correctly for the MFE service. I also verified that the service was serving static files as expected. |
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the previous comments and confirming this was tested. Looks good!
|
@brian-smith-tcril, I'll let you do the honors. |
Description
This pull request introduces support for mounting Paragon theme static files into the MFE Kubernetes deployment. The changes ensure that the correct theme CSS files are generated, made available as config maps, and mounted as read-only volumes in the application pods.
Kubernetes config and volume management:
paragon-static-filesconfig map generator tokustomization-configmapgeneratorfor including core and theme CSS files, dynamically supporting multiple themes.mfe-k8s-volumesto create astatic-filesvolume from the generated config map, mapping core and theme CSS files to their respective paths.mfe-k8s-volume-mountsto mount thestatic-filesvolume at/paragon-staticsas read-only in the MFE containers.