Skip to content

fix: backport openedx-forum 0.4.1 to ulmo for thread sort bug#38710

Open
taimoor-ahmed-1 wants to merge 1 commit into
openedx:release/ulmofrom
edly-io:backport/openedx-forum-0.4.1-ulmo
Open

fix: backport openedx-forum 0.4.1 to ulmo for thread sort bug#38710
taimoor-ahmed-1 wants to merge 1 commit into
openedx:release/ulmofrom
edly-io:backport/openedx-forum-0.4.1-ulmo

Conversation

@taimoor-ahmed-1
Copy link
Copy Markdown
Contributor

Summary

Bumps the openedx-forum pin from 0.3.8 to 0.4.1 on release/ulmo to backport the fix for the discussion-forum "pinned"-NULL sort bug.

Companion PR for release/teak: #38709.

What's in 0.3.8 → 0.4.1?

forum tag what it adds safe for Ulmo?
0.3.9 Five small bug fixes (Mongo content_type, timestamps, MySQL read_states lookup, Forum V2 author field, build CI)
0.4.0 MySQL backend N+1 / query optimizations (select_related / prefetch_related); backwards-compatible per commit message
0.4.1 The fix + optional Typesense search backend (off by default)

Why cap at 0.4.1?

A constraint openedx-forum<=0.4.1 is added to requirements/constraints.txt to keep the Ulmo line on the safe side of two breaking releases:

forum tag change safe for Ulmo?
0.4.2 Drops Python 3.11 support ❌ if Ulmo still supports 3.11
0.4.3 Removes the MongoDB backend ❌ (Ulmo deployments may still use MongoDB)

The constraint should be dropped on master / post-Ulmo release lines.

Files changed

  • requirements/constraints.txt — adds the openedx-forum<=0.4.1 cap with an explanatory comment block.
  • requirements/edx/{base,development,testing,doc}.txt — bumps the pinned openedx-forum line from 0.3.8 → 0.4.1, and adds the new transitive typesense==2.0.0 dep that 0.4.1 pulls in.

httpx, httpcore, h11, and anyio (typesense's other transitive deps) are already pinned in release/ulmo's base.txt, so the only new pin added is typesense==2.0.0.

If preferred, maintainers can re-run make upgrade-package package=openedx-forum to regenerate the compiled files canonically — the resulting diff should match this PR.

Test plan

  • Tutor Ulmo deployment running openedx-forum==0.4.1 no longer shows old threads at the top of "recent first" sort.
  • Forum migration 0005_alter_commentthread_pinned applies cleanly and pinned column has no NULL rows after manage.py lms migrate.
  • CI passes — make upgrade-package package=openedx-forum produces no further changes.

🤖 Generated with Claude Code

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 4, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @taimoor-ahmed-1!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 4, 2026
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the backport/openedx-forum-0.4.1-ulmo branch from 8cdfa6f to 5e9e745 Compare June 4, 2026 11:09
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jun 4, 2026
Bumps the `openedx-forum` pin from 0.3.8 to 0.4.1 on `release/ulmo`
to pull in the fix for the "pinned"-NULL sort bug
(openedx/forum#270, commit 78b36e4) where discussion threads were
not ordering correctly when users selected "recent first" — old
threads with NULL `pinned` values floated above newer threads.

Reported in:
https://discuss.openedx.org/t/discuss-forum-messages-order-not-organized-as-expected-in-teak/18665

The 0.3.8 -> 0.4.1 delta brings in:
  * 0.3.9 — five small bug fixes (Mongo content_type, timestamps,
    MySQL read_states lookup, Forum V2 author field, build).
  * 0.4.0 — MySQL backend query optimizations (N+1 fixes,
    prefetch/select_related); backwards compatible.
  * 0.4.1 — the `pinned` NULL sort fix (commit 78b36e4) plus the
    optional Typesense search backend (additive, off by default).

Caps openedx-forum at <=0.4.1 in constraints.txt to avoid:
  * 0.4.2 — drops Python 3.11 support.
  * 0.4.3 — removes the MongoDB backend (Ulmo deployments may rely on it).

The constraint should be removed on master / post-Ulmo release lines.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the backport/openedx-forum-0.4.1-ulmo branch from 5e9e745 to 339c459 Compare June 5, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants