-
Notifications
You must be signed in to change notification settings - Fork 27
docs: [FC-0074] add documentation for in-line code annotations #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @mariajgrimaldi! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
bmtcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
120ed68 to
b2b2580
Compare
* docs: [FC-0074] add glossary for openedx-events ecosystem (#407) * docs: [FC-0074] add real life use cases based on community adoption (#416) * docs: [FC-0074] add more detailed concepts on events (#406) Improves the concept section of the documentation by adding a new document dedicated only to Open edX Events. * docs: [FC-0074] reference main hooks docs (#424) * docs: [FC-0074] add details for illustrating how events work (#420) * docs: improve format and wording in concepts docs (#425) * Add quote block to Django signals definition from Django docs * Reference list of use cases in how are events used * Use "send events internally" instead of within the same app process to improve readability * docs: [FC-0074] update PR template to reflect latest requirements for repo (#430) * docs: [FC-0074] explain how the event bus works and how to use it (#426) * docs: add documentation for in-line code annotations (#432) * chore: update requirements for build to work --------- Co-authored-by: Maria Grimaldi <[email protected]>
Description
To improve visibility, this PR moves the in-line code annotation docs for events from a how-to to the reference category.
Supporting information
This comment addresses this comment: openedx/code-annotations#136 (comment). Once we merge it and make it available, we should reference this new document here https://github.com/openedx/code-annotations/blob/master/code_annotations/contrib/config/openedx_events_annotations.yaml#L9.
Testing instructions
You can see the docs when generated here: https://docsopenedxorg--432.org.readthedocs.build/projects/openedx-events/en/432/reference/in-line-code-annotations-for-an-event.html
Deadline
None
Other information
NA
Checklists
Check off if complete or not applicable:
Merge Checklist:
Post Merge:
finished.